Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashtag with appname in notes #642

Merged
merged 1 commit into from Sep 28, 2023
Merged

Conversation

deevroman
Copy link
Contributor

@deevroman deevroman marked this pull request as ready for review September 26, 2023 08:34
@Zverik
Copy link
Owner

Zverik commented Sep 26, 2023

Do other apps do this? I disliked the initial issue because it's one over-active person peddling the topic. Like, what's the point?

(Thanks for making the pull request nevertheless. I'll merge this if it's the way to go, after improvements.)

@mnalis
Copy link
Contributor

mnalis commented Sep 26, 2023

I disliked the initial issue because it's one over-active person peddling the topic

There have been 5 likes (and no dislikes) on that issue though, as well as 14 likes (and no dislikes) on related community forum discussion, so I wouldn't view that one person being vocal (about that issue they care about) as problematic at all (quite the opposite in fact, perseverance can be a virtue too).

Do other apps do this?

At least StreetComplete does add its name in the Notes, although as "via StreetComplete 53.0" text (instead of hashtag-like "#StreetComplete_53.0"). e.g. https://www.openstreetmap.org/note/3742136

MapComplete seems to do it too (e.g. https://www.openstreetmap.org/note/3715951)

Like, what's the point?

I personally find that feature useful too (just like I find changeset created_by useful metainformation too) - it even helped track down and isolate few StreetComplete bugs. It also may point to UI inconsistencies and areas for improvements (e.g. if people leave a lot of notes to add some feature, it might indicate that feature needs to be added to presets). And of course all metadata is useful in and by itself (for example for various statistics, usage patterns etc), finding the source of problematic notes etc.

That being said, I rarely use Notes mode in EveryDoor in its current state though, as I find it lacking compared to e.g. StreetComplete (e.g. taking pictures with direction, direction shown on the map #255) or OsmAnd Notes (map direction, detailed many POIs&notes visible at all times) UIs. (e.g. missing pointer, #459, different sized maps for different mapping modes make it hard to orient, #615 (comment))

@deevroman
Copy link
Contributor Author

The editor through which the note is left is a good clue that the note is left from a local mapper. In theory it can be understood by the changesets of the mapper in the same time period. But in practice you don't want to look at other users' changesets.

Another benefit is that you can analyse the statistics of notes by editors.

Minus: additional text in the note.


Maybe you can do without the hashtag and add the application version. Or put this behaviour in the hashtag settings. You can do what you think is best.

@Zverik
Copy link
Owner

Zverik commented Sep 28, 2023

Okay I've slept on it and decided it can live :) What I'd like is one empty line between the text and the hashtag, and proper capitalization (EveryDoor).

@Zverik Zverik merged commit e482cfc into Zverik:main Sep 28, 2023
@Zverik
Copy link
Owner

Zverik commented Sep 28, 2023

Thank you Roman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants