Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use Dropout for input features/dmdt's #53

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

dmitryduev
Copy link
Collaborator

Randomly dropping input feature/dmdt data is a bad idea and I'm not sure why I had it there in the first place. My guess is that the DNN performance will significantly improve once that is removed.

Randomly dropping input feature/dmdt data is a bad idea and I'm not sure why I had it there in the first place. My guess is that the DNN performance will significantly improve once that is removed.
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embarrassed to say that we should have realized the same on initial review ;)

@mcoughlin
Copy link
Collaborator

Do you understand the keras complaints @dmitryduev ?

@dmitryduev
Copy link
Collaborator Author

I'd guess that tf just lives a very intense life that we should all be envious about. Let's see if my hypothesis is correct.

@dmitryduev
Copy link
Collaborator Author

there you go @mcoughlin!

@mcoughlin mcoughlin merged commit 92e380d into main Nov 3, 2021
@dmitryduev dmitryduev deleted the no-dropout-at-input branch November 3, 2021 20:29
@bfhealy bfhealy mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants