Added the ability to close a directory node #271
Conversation
| @@ -191,7 +191,7 @@ pub const FileNode = struct { | |||
|
|
|||
| /// See the documentation for FileSystem.Close | |||
| pub fn close(self: *const FileNode) void { | |||
| return self.fs.close(self.fs, self); | |||
| return self.fs.close(self.fs, @ptrCast(*const Node, self)); | |||
There was a problem hiding this comment.
Instead of casting it would make more sense if this function becomes part of the Node struct.
There was a problem hiding this comment.
This wouldn't work as you can't close a symlink. Plus openFile and openDir return FileNode and DirNode so there will need to be a cast at some point.
There was a problem hiding this comment.
I reckon we could close a symlink, after all it's going to be kept around in memory by the FS and we'll want to get rid of it from memory once it isn't used. openFile and openDir do indeed return specialised nodes, but when converting a Node to a DirNode or FileNode we switch on them rather than cast since it's much safer and allows us to detect invalid nodes being passed.
There was a problem hiding this comment.
How would you do back from a FileNode or DirNode to a Node?
There was a problem hiding this comment.
Well you wouldn't have to if the function is part of Node and takes a *Node or *const Node as self.
There was a problem hiding this comment.
I had a look, but changes a lot of types from FileNode and DirNode to just Node and mean that I will need to change the mount type to Node instead of DirNode. I'm not sure how to do this. Could you show me da way sensei.
Was thinking of having 2 close functions, one for FileNode and one for DirNode.
There was a problem hiding this comment.
Oh I see that the problem is that with this a close function that takes a Node we can't do
var file = vfs.openFile(...)
file.close()
A solution is to have a close function in in FIleNode and DirNode like you do now, then have a close function for each of those in FileSystem (i.e. closeFile, closeDir). This avoids the casting that could be dodgy. I'm not sure how to tackle closing symlinks, that could be tended to later on.
DrDeano
force-pushed
the
feature/vfs-close-dir
branch
2 times, most recently
from
9454a04
to
8eba38b
Compare
Updated docs Closes #270 Update doc comment Moved close to closeFile and closeDir in VFS Moved back to @ptrCast() Always forget to format Added TODO comment
DrDeano
force-pushed
the
feature/vfs-close-dir
branch
from
8eba38b
to
0497beb
Compare
Closes #270