Putting arch file into a package. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamTebbs33
requested changes
Jun 13, 2022
Dawid33
force-pushed
the
arch-package
branch
4 times, most recently
from
3a8017a
to
d53c10b
Compare
|
Sorry for the stream of force pushes, I got it working properly. I thought it wasn't possible to have circular references but it actually is :), I went off a on a tangent yesterday haha. Most of the tests are passing. Still needs some work. |
Dawid33
force-pushed
the
arch-package
branch
2 times, most recently
from
c7cb85d
to
f2b9df3
Compare
DrDeano
reviewed
Jun 18, 2022
This was referenced Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #77
Unfortunately, arch.zig and the kernel are dependant on each other. I couldn't think of a way to have two pacakges directly depend on each other. I made a file pluto.zig that collects and re-exports all the files in the kernel. I made packages out of arch.zig and pluto.zig. kmain.zig then imports those packges.
This works for just running the kernel but getting the tests to work will be a bigger challenge.