New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import all service roads #449
Comments
This will make it easier to visually track the progress improving the import. Originally London was added to have one left-hand driving map under the test, but Cambridge works for that too, and it also includes separate cycleways. Also fix a crash when trying to draw very very tiny arrows.
|
Cambridge has a significant pedestrian plaza, tagged as |
Backing up a little, importing some of these "fancier" OSM pieces has a few criteria for success:
For each aspect of Cambridge that we're trying to model in more detail, we should be clear which of these 3 are important. |
https://www.openstreetmap.org/way/3998383#map=17/52.19614/0.11652 |
https://www.openstreetmap.org/way/4195851 |
Great to see this being tracked here @dabreegster. Heads-up @mvl22 we can talk about import of cycleways and other OSM features here, and hopefully implement some of your ideas from the OSM talk! |
In the UK, |
Yes, the central area does have both pedestrian area as well as highway=pedestrian. This is actually reflective of there being clearly-demarcated roadway edges within this pedestrian area anyway. |
Service roads in the UK should definitely considered be relevant to cycling, even if they are not always pleasant. |
Since we have to regenerate everything anyway, also start importing landuse=meadow areas for #449.
changes when I downloaded it. #449 And a small parking fix to better investigate a live edit crash.
intersection. When the signal happened to be on a node that didn't alter the angle of the road, it was incorrectly getting dropped before. Not regenerating all map data just yet, but manually verified along Newmarket Rd in Cambridge. #449
Fix a bug with the previous commit (lanes=1 on a two-way). Now regenerate. ... Unfortunately lakeslice now gridlocks due to a turn generation bug. Temporarily removing the prebaked results there so I can push these last few changes through. Will resolve this before the next release.
Looking at the comments above I think big progress has been made on this issue - the import for UK cities and cycleways has been greatly improved! Any other aspects of the import to work on (thinking from an ActDev perspective)? I think this issue can be closed if these criteria have been met (there are always a few edge cases):
|
Main gap left is probably importing all service roads. There are some complications with doing that I'll describe and work through. |
Aha makes sense, thanks for the update. My side, we're almost there with the build for all sites, just pushed updated data for ashton park. |
I took another pass at this, and I think I should have something working in a few hours. All service roads except for driveways will be imported. There are a few complications, but no blockers. First, parking aisles. Many, like https://www.openstreetmap.org/way/565125051, are untagged, but A/B Street needs to understand these cross a parking lot and should be used to autogenerate individual spaces. Second, access restrictions. Sometimes there's a gate tagged as a node, like https://www.openstreetmap.org/node/3958600551. Ideally we could cluster the group of service roads together and set an access restricted zone with no through-traffic allowed. Might not do this on the first pass; just have to watch and make sure lots of vehicles don't start trying to route through it. Third, many service roads in OSM give a precise connection between a building or parking lot and main road. Ideally abst would make use of that, but
So I think for now, still going to punt on this issue. The practical effect is that some parking lots wind up with an autogenerated driveway that snaps to the wrong road. Not a huge issue. I'm looking at the diffs after importing more service roads, and they're generally quite helpful. For example, the uvillage shopping area in Seattle looks like this before: |
https://wiki.openstreetmap.org/wiki/Tag:service%3Dparking_aisle#Disambiguation |
I also noticed this monstrosity appear in SODO: |
Added an extra step to classify service roads as running through a parking lot, to prevent them from being treated as regular roads. Had to fix up a few prebaked traffic signals. lakeslice falls back into gridlock; will fix separately -- too much effort behind this change to stop.
Some fallout left to address from the previous change, but more or less, this is done. I see plenty around Cambridge. As we move towards polishing for actdev, we can hand audit a few sites that're well-known and spot anything missing. |
Great work importing the service roads, look forward to seeing how this changes the visualisation for our case study sites. Many thanks Dustin! |
Separate cyclepaths like https://www.openstreetmap.org/way/54563641 excluded; let's try enabling them.
https://www.openstreetmap.org/way/4188078 has
cycleway:left
, but it winds up on the right -- I think the left-hand driving side needs some fixes here.The text was updated successfully, but these errors were encountered: