Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the transformation that shrinks overlapping roads. #167

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

dabreegster
Copy link
Contributor

#159
This is indeed too blunt an instrument. I considered keeping it just for A/B Street, but I don't really want to rely on things we're not testing here, and it's only slightly helping in some situations that're broken anyway.

Some particularly notable regressions (where we were just kind of getting lucky before):
Screenshot from 2023-01-03 16-04-50
Screenshot from 2023-01-03 16-04-45
Screenshot from 2023-01-03 16-02-41
Screenshot from 2023-01-03 16-02-35

These were problems that came up in #136 (comment). I think merging this first will make the transition to geometry-as-an-operation easier.

@dabreegster
Copy link
Contributor Author

Noting that in the first example (seattle_slip_lane), there's overlap because we incorrectly infer sidewalks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant