Start a new transformation that merges a class of parallel cycleways to #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the main road, preserving lanes. #59 Disabled by default.
dabreegster
commented
Aug 11, 2022
| // might be more. | ||
| let main_road_i1 = main_road_endpoints[0]; | ||
| let main_road_i2 = main_road_endpoints[1]; | ||
| // Find all main road segments "parallel to" this cycleway, by pathfinding between |
There was a problem hiding this comment.
We could perhaps be more paranoid here by checking that the cycleway center line and all of the main road center lines are nice and parallel. If they curve away from each other a bit, then even if the connection roads are under our threshold of 10 meters, we may lose some geometric information by snapping.
|
|
||
| streets.debug_road(r, format!("snap_to_left = {snap_to_left}, oriented_same_way = {oriented_same_way}, insert_idx = {insert_idx}")); | ||
|
|
||
| // This logic thankfully doesn't depend on driving side at all! |
There was a problem hiding this comment.
I struggled to write this without scribbling diagrams on paper and using temporary debug visualization. It was a similar experience to sausage links. I hope there will be some better patterns to reason through this kind of thing. Maybe #1 is relevant.
This was referenced Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main road, preserving lanes. #59
Disabled by default.
I have been puzzling through how to simplify cases like this for a long time, but the last progress was almost two years ago: a-b-street/abstreet#348. I took a fresh approach by
The result is delightful. Along Roosevelt in Seattle, before:
and after:
The red lane is the buffer lane inserted. With additional tagging in OSM, we can know if these are flex posts, concrete bollards, a Jersey barrier, striping, etc.
And much more extravagantly, St George's just past the Elephant & Castle roundabout. Before:
After:
As you can see to the right, the algorithm is far from finished. It gets confused by the "triangular" shape of the cycleway graph there and just leaves it alone. I'm leaving this transformation disabled until more dramatic problems are fixed, like in Taipei... before:
Note this paradise of parallel cycletrack is actually mostly-pedestrian space in reality, but that's another issue. After:
Clearly something went very wrong. I'll improve the incremental interactive debugging and figure out what. Right now the debugging is shown for all cycleway segments at the same time; we can split this into smaller steps.
