Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infinite loop if go.mod not found, warn on missing go.mod or forgotten go get #441

Merged
merged 9 commits into from
Jan 20, 2024

Conversation

a-h
Copy link
Owner

@a-h a-h commented Jan 19, 2024

Fixes #418

@a-h a-h mentioned this pull request Jan 19, 2024
@joerdav
Copy link
Collaborator

joerdav commented Jan 19, 2024

I'm wondering if the lack of a go.mod should not be an error. Since they are an optional feature of go.

@a-h a-h marked this pull request as ready for review January 20, 2024 01:39
@a-h
Copy link
Owner Author

a-h commented Jan 20, 2024

Although it prints an error if the go.mod is not present, it doesn't actually stop anything @joerdav

@joerdav
Copy link
Collaborator

joerdav commented Jan 20, 2024

Ah yeah, it doesn't exist just a warning log, I forgot about that one! Cool LGTM

@joerdav
Copy link
Collaborator

joerdav commented Jan 20, 2024

One thing, the test project could go in a testdata folder, then it'll only ever be compiled on test runs.

@a-h a-h merged commit cac13b5 into main Jan 20, 2024
7 checks passed
@a-h a-h deleted the go_mod_check_fail branch January 20, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd: Endless loop causes 100% CPU load and hangs templ
2 participants