Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate to Go parser instead of using heuristics #461

Merged
merged 19 commits into from
Jan 29, 2024
Merged

refactor: migrate to Go parser instead of using heuristics #461

merged 19 commits into from
Jan 29, 2024

Conversation

a-h
Copy link
Owner

@a-h a-h commented Jan 25, 2024

This should make parsing Go code within templ files more robust, since it uses the actual Go parser.

a-h added 16 commits January 22, 2024 09:24
@a-h
feat: migrate calltemplateparser to Go AST parser
6f9f06c
@a-h
feat: migrate conditional attributes to go AST parser
fd913e1
@a-h
refactor: remove length param from go parser
004754b
@a-h
refactor: migrate boolean attribute to Go AST parser
fc4782e
@a-h
refactor: migrate expression attribute parser to goexpression
a22aa3d
@a-h
refactor: migrate spread attribute expression to Go AST parser
d669df5
@a-h
feat: migrate for expression to AST parser
a487293
@a-h
feat: migrate if expression to AST parser
ad157a4
@a-h
feat: migrate string expression to AST parser
f34c13b
@a-h
feat: migrate switch expression to Go AST parser
6ee1e4e
@a-h
feat: migrate template parser to Go AST parser.
01d0fdb
@a-h
feat: migrate templ element parser to Go AST parser
70fec94
@a-h
refactor: remove dead code
ca5a2f5
@a-h
chore: remove dead code, bump deps hash
1b909bd
@a-h
fix: add unit test for #232
3d971bf
@a-h
chore: tidy go.sum
838b795
@a-h a-h marked this pull request as ready for review January 25, 2024 21:21
@a-h a-h requested a review from joerdav January 25, 2024 21:21
@a-h a-h mentioned this pull request Jan 26, 2024
Closed
joerdav
joerdav reviewed Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@joerdav joerdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, big fan of the go parse tests, should be really easy to add new ones without it becoming a huge unreadable file!

Just added a couple nits and some typos I spotted.

parser/v2/conditionalattributeparser.go Show resolved Hide resolved
parser/v2/goexpression/parse.go Outdated Show resolved Hide resolved
parser/v2/goexpression/parse.go Outdated Show resolved Hide resolved
parser/v2/templelementparser.go Outdated Show resolved Hide resolved
@a-h a-h merged commit 3de67f6 into main Jan 29, 2024
5 of 6 checks passed
@a-h a-h deleted the go_ast_v2 branch January 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerdav joerdav joerdav left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a-h @joerdav