docs: fix gin html status code overwrite and provide fallback renderer #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt http status code) and optionally add fallback html renderer to gin HTMLRender if no temp component is provided
joerdav
changed the title
a-h
reviewed
Feb 26, 2024
| engine.HTMLRender = gintemplrenderer.Default | ||
| engine.LoadHTMLFiles("./home.html") | ||
|
|
||
| //engine.HTMLRender = gintemplrenderer.Default |
There was a problem hiding this comment.
This seems like it's been left behind.
There was a problem hiding this comment.
Default is the old (retrocompatible) way if you do not want to provide a fallback renderer
Comment on lines
+16
to
+17
| ginHtmlRenderer := engine.HTMLRender | ||
| engine.HTMLRender = &gintemplrenderer.HTMLTemplRenderer{FallbackHtmlRenderer: ginHtmlRenderer} |
There was a problem hiding this comment.
This doesn't feel right. I don't see why the variable exists.
There was a problem hiding this comment.
the variable can be removed indeed, it was to make the code a little more readable so that user can understand that here we are setting a fallback to gin default html renderer in case we do not pass a templ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to better integrate with gin.HTML function (allow different http status code) and optionally add fallback html renderer to gin HTMLRender if no temp component is provided