Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes issue #597 - improves performance (500x faster than previous) #605

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

a-h
Copy link
Owner

@a-h a-h commented Mar 10, 2024

No description provided.

@joerdav
Copy link
Collaborator

joerdav commented Mar 11, 2024

All the code looks solid to me, I also tested it on my shopping-list repo, which doesn't really benefit form the performance increase much, but it does still work.

One thing with these open/close counters is I get skittish about some scenarios like f("hello world{"), where strings contain open or close brackets. Looking at the code I think we're fine, but could do with a few test cases to be positive.

Would also probably be an ideal time to run the fuzz tests again!

@a-h a-h merged commit ee4d1dd into main Mar 15, 2024
7 checks passed
@a-h a-h deleted the issue_597_parse_performance branch March 15, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants