Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting an error in GHA #16

Closed
max-sixty opened this issue Sep 11, 2022 · 7 comments · Fixed by #17 or #19
Closed

Getting an error in GHA #16

max-sixty opened this issue Sep 11, 2022 · 7 comments · Fixed by #17 or #19

Comments

@max-sixty
Copy link

Hi there,

I recently changed our minor-version-delta from 2 to 1.

Our cron job now breaks — https://github.com/prql/prql/runs/8292688495?check_suite_focus=true — is that something we're doing wrong?

The only change to the job was that character (https://github.com/prql/prql/pull/958/files), so I'm confused what might be going wrong.

Thank you v much again!

a-kenji added a commit that referenced this issue Sep 11, 2022
On multiple patch versions, they are split correctly.
This fixes `sed` expression syntax in these circumstances.

Closes: #16
@a-kenji
Copy link
Owner

a-kenji commented Sep 11, 2022

Hi @max-sixty,

Thank you for reaching out.
This was a bug on our side, you did nothing wrong!
I expect it to be fixed now, but would be happy if you could test it again and confirm it.

@max-sixty
Copy link
Author

Thanks @a-kenji ! It runs every week so I'll post back if it fails next week.

@max-sixty
Copy link
Author

Hi @a-kenji — is it pulling the correct version?

I'm still get an error (https://github.com/prql/prql/actions/runs/3044445552/jobs/4904842290)

But if I unpin the version, GHA complains: PRQL/prql#963

Thanks!

@a-kenji
Copy link
Owner

a-kenji commented Sep 13, 2022

@max-sixty,
I will release a version for the fixes fairly soon.
Does a-kenji/update-rust-toolchain@main work currently?
Thanks for the information!

@max-sixty
Copy link
Author

I'm actually getting a different error now; maybe @main isn't supported? https://github.com/prql/prql/actions/runs/3048152751/jobs/4912914296

a-kenji added a commit that referenced this issue Sep 13, 2022
This might fix: #16 (comment)

Add the `head-ref` as default input.

Ref: peter-evans/autopep8#59
@a-kenji
Copy link
Owner

a-kenji commented Sep 13, 2022

This was a different error that surfaced now, I believe that I fixed it with #19.
So I expect it to work with @main now.
Thank you for all the patience and help with debugging!

@max-sixty
Copy link
Author

Great — it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants