Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gregorian calendar has 365.2425 days per year #1

Closed
barrycarter opened this issue Jan 14, 2023 · 3 comments
Closed

Gregorian calendar has 365.2425 days per year #1

barrycarter opened this issue Jan 14, 2023 · 3 comments

Comments

@barrycarter
Copy link

In our current Gregorian calendar, there are 365.2425 days, not 365.25. You should either correct for this or at least mention in the code you are using a non-Greogrian calendar.

@a-p-jo
Copy link
Owner

a-p-jo commented Jan 15, 2023

Thank you very much for opening this issue!

Yeah, the code says a year is 31557600 seconds, which is 365.25 days and is the unit used in the Julian calendar rather than the Gregorian one. This needs fixing; I hadn't quite realized this before.

On further research, I also discovered solar time and the concept of the mean tropical year.

Would you prefer the tool to use the Gregorian calendar year (365.2425 days) or the mean tropical year (365.24219 days)?

@a-p-jo
Copy link
Owner

a-p-jo commented Jan 16, 2023

@barrycarter In the latest commits, I've added the ability to select among half a dozen year types and the default is the gregorian year. This can be configured in config.h.

Let me know if this fixes the issue.

@barrycarter
Copy link
Author

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants