Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache connection string, use connection string factory instead #1

Open
vgribok opened this issue Nov 1, 2019 · 4 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@vgribok
Copy link

vgribok commented Nov 1, 2019

Current implementation of AddPostgreSql() and PostgreSqlHealthCheck() caches connection string for the lifetime of the running application. This goes against the dynamic nature of IConfiguration that allows dynamic reloading and usage of configuration settings without having to restart the application.

Please follow .NET Core Framework pattern for adding SQL Server health check for an example.

@a-patel a-patel added enhancement New feature or request good first issue Good for newcomers labels Nov 1, 2019
@a-patel
Copy link
Owner

a-patel commented Nov 1, 2019

@vgribok
Could you please share your code for dynamic configuration?

@vgribok
Copy link
Author

vgribok commented Nov 1, 2019

@a-patel
Copy link
Owner

a-patel commented Nov 1, 2019

Got it. I will add a new feature.
Thanks @vgribok

@a-patel
Copy link
Owner

a-patel commented Nov 1, 2019

I have already started working on upgrading all LiteXHealthChecks to .NET Core 3.0.
I will add factory support for all packages.

@a-patel a-patel self-assigned this Nov 1, 2019
@a-patel a-patel added this to the Version 2.0.0 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: QA
Development

No branches or pull requests

2 participants