Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProteinGraphDataset fails if a single graph construction fails. #345

Open
kamurani opened this issue Sep 20, 2023 · 0 comments
Open

ProteinGraphDataset fails if a single graph construction fails. #345

kamurani opened this issue Sep 20, 2023 · 0 comments

Comments

@kamurani
Copy link
Contributor

When using the ProteinGraphDataset class, if a single graph fails construction in construct_graphs_mp, the graph will be passed to transformation functions as None and this will often cause them to fail.

If None graphs are filtered out of the data_list, then a list index out of range error will result as the loop that saves the torch Data objects, as it saves the filenames from the original pdb list (list of uniprot ids) and is not aware which specific IDs had failed graph constructions.

Expected behavior
The ProteinGraphDataset should be robust in handling failed graph constructions and store a list of failed / successful graphs, so that the returned object can be used with valid indexes still (and the user can be aware of which samples in the newly constructed dataset are not able to be used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant