[DO NOT MERGE] Adds experiments to simple app #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladikoff
reviewed
Jul 22, 2020
| Thread { | ||
| GlobalScope.launch { | ||
| var exp = mozilla.components.service.glean.Experiments | ||
| exp.initialize("https://kinto.dev.mozaws.net/v1/", |
There was a problem hiding this comment.
@tarikeshaq for initialize can the API something like: .initialize(experimentsContext, dataDir, [ServerConfig]
where
- experimentsContext - is gonna be the struct of all the fields we need for the experiments
- dataDir - data directory for our state and stuff
- Optional ServerConfig, like we have in FxA. We can hardcode the 2-3 kinto environments into the module at this time.
| "messaging-collection", | ||
| "main", | ||
| applicationContext.dataDir.path) | ||
| val res = exp.getBranch("button-color") |
There was a problem hiding this comment.
a TODO here for us would be something like:
- Send an enrolled event for the experiment
- Send a saw
button-colorbutton. AKA "User saw some branch of the experiment"
tarikeshaq
force-pushed
the
test-experiments-do-not-merge
branch
from
8af1b3a
to
49c03d9
Compare
tarikeshaq
force-pushed
the
test-experiments-do-not-merge
branch
from
49c03d9
to
2a55e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be pulled for local testing of the experiments prototype in glean.
You'll have to first publish glean to maven local.
Publishing Glean with prototype to mavenLocal
First, clone
a-s-dev's Glean forkThen, switch to the
test-experiments-do-not-mergebranch:Then publish glean to mavenLocal
Running experiments API from Android Components
Make sure you are on this branch (
test-experiments-do-not-merge), on thea-s-devfork of android components.Then you can run/debug the
samples-gleanapp in AC and it would be calling into the rust-experimenter inGleanApplication.kt. So far it initializes the components, which uses viaduct to request experiment information, and it persists that information for the next time you run it.