Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature preview is missing bottom-right border #5

Closed
iaik-jheher opened this issue Nov 22, 2022 · 1 comment · Fixed by #87 or #111
Closed

Signature preview is missing bottom-right border #5

iaik-jheher opened this issue Nov 22, 2022 · 1 comment · Fixed by #87 or #111
Labels
🚧 issue ⚙️ Upstream: PDF-AS 😔 waiting for upstream 🤕 workaround

Comments

@iaik-jheher
Copy link
Contributor

(Issue migrated from Gitlab: Internal link)

The signature preview displayed in the options dialog is missing its bottom-right border. This is an issue in the preview generated by PDF-AS.

Issue filed internally with them: Internal link on 2022-08-04.

Currently workarounded by 03b8091, we manually draw a border over the generated preview.
iaik-jheher added a commit that referenced this issue Apr 28, 2023
@iaik-jheher
remove pdf-as workaround for image rendering, cf #5
3de8fef
@iaik-jheher iaik-jheher mentioned this issue Apr 28, 2023
Merged
iaik-jheher added a commit that referenced this issue Dec 1, 2023
@iaik-jheher
Remove assorted PDF-AS workarounds & close issues (#87)
be69388 
cf. #5, #9, #12, #13, and #14.
@iaik-jheher iaik-jheher reopened this Dec 1, 2023
iaik-jheher added a commit that referenced this issue Dec 1, 2023
@iaik-jheher
re-add the #5 workaround for now, it's still happening
05a6338
@iaik-jheher
Copy link
Contributor Author

Update for 4.4.6 release prep (PDF-AS 4.3.2): this still happens.

iaik-jheher added a commit that referenced this issue Jan 15, 2024
@iaik-jheher
bump pdf-as version & remove workarounds
548a706 
cf. #5, #9, #12, #13, #14
@iaik-jheher iaik-jheher mentioned this issue Jan 15, 2024
Merged
iaik-jheher added a commit that referenced this issue Jan 16, 2024
@iaik-jheher
Update PDF-AS to 4.4.0 (#111)
88225a5 
closes #5 #7 #9 #12 #13 #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚧 issue ⚙️ Upstream: PDF-AS 😔 waiting for upstream 🤕 workaround
Projects
None yet
Milestone
No milestone
1 participant
@iaik-jheher