Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's do some country flags #13

Closed
camilstaps opened this issue Jan 20, 2017 · 5 comments
Closed

Let's do some country flags #13

camilstaps opened this issue Jan 20, 2017 · 5 comments

Comments

@camilstaps
Copy link

camilstaps commented Jan 20, 2017

The flag of Micronesia, taken from https://github.com/maxyz/iso-country-flags-svg-collection/blob/master/svg/country-4x3/fm.svg?short_path=4c61732, gives an incorrect result:

2017-01-21-002317_453x344

It should look like here: the rightmost star is miss-aligned.

The tool, which I run with --fix-fill-type (though it doesn't seem to matter for this SVG), does not report any warnings or errors.

Software versions:

$ inkscape --version
Inkscape 0.92.0 r15299
$ mono --version
Mono JIT compiler version 4.6.2 (Stable 4.6.2.16/ac9e222 Tue Jan  3 11:48:26 UTC 2017)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
        TLS:           __thread
        SIGSEGV:       altstack
        Notifications: epoll
        Architecture:  amd64
        Disabled:      none
        Misc:          softdebug 
        LLVM:          supported, not enabled.
        GC:            sgen

Thanks for the great tool, I was pleasantly surprised to find that things like the flag of Mexico are converted perfectly.


I did some more testing and found that these flags also have some issues (which do not get warnings):

  • Argentina (sun rays not aligned correctly, one out of view)
  • Andorra (text)
  • Afghanistan (proportions of vertical bars)
  • Bosnia and Herzegovina (stars are too wide)
  • Bouvet Island (vertical bars extend outside of view)
  • I stopped testing here, there might be more :)
  • Portugal takes a very long time with --fix-fill-type (over 15 minutes) (technically not a bug and perhaps not fixable?)
@camilstaps
Copy link
Author

I'm not using this tool any more, so I don't really mind...

@a-student
Copy link
Owner

I believe it should be open until fixed.

@a-student a-student reopened this Jul 5, 2017
@bhargavms
Copy link

@camilstaps I would like to know what tool are you using instead? if you dont mind me asking.

@camilstaps
Copy link
Author

I'm using PNG country flags instead.

https://github.com/camilstaps/ReverseBeaconClient

a-student added a commit that referenced this issue Sep 3, 2017
a-student added a commit that referenced this issue Sep 3, 2017
a-student added a commit that referenced this issue Sep 3, 2017
a-student added a commit that referenced this issue Sep 3, 2017
@camilstaps
Copy link
Author

Cleaning up my issues list. If you want to keep the issue around, please open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants