Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension is way too big #1

Closed
inosik opened this issue Oct 12, 2017 · 4 comments
Closed

Extension is way too big #1

inosik opened this issue Oct 12, 2017 · 4 comments

Comments

@inosik
Copy link

inosik commented Oct 12, 2017

The extension contains ~30 MB of Node packages. Please add a .vscodeignore file to only include files which are needed.
@a-wart
Copy link
Owner

a-wart commented Oct 12, 2017 •
edited
Loading

@inosik thanks for noticing that.
done and re-published now:)
a6d7628

@a-wart a-wart closed this as completed Oct 12, 2017
@inosik
Copy link
Author

inosik commented Oct 12, 2017

Yeah, the first install took like forever 😄

Thanks!

@inosik
Copy link
Author

inosik commented Oct 12, 2017

Version 0.0.3 still has all the Node packages 😕

All the other .vscodeignore files I've seen add ** to the directory names. Maybe you should do the same?

@a-wart
Copy link
Owner

a-wart commented Oct 12, 2017 •
edited
Loading

@inosik oh, I see. but it's strange to make .[something]ignore to behave not like .gitignore does
— and that confused me.)
I've republished theme with /** pattern in .vscodeignore anyway in v0.0.4, thank you

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-wart @inosik