Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "--parent" option to create-issue command #16

Closed
wants to merge 7 commits into from

Conversation

pedropb
Copy link
Contributor

@pedropb pedropb commented Nov 15, 2016

Adding "--parent" option to create-issue command, allowing sub-tasking.

I created a PR for this before, but it was bugged when the command was issued without --parent option. I used the same workaround that was already presented in the code for --parent option of create-project command.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 87bd6bf on pedrobaracho:create-issue-parent-option into f38d3d8 on a11n:master.

@a11n a11n added this to the v0.9.0 milestone Nov 15, 2016
@a11n a11n self-assigned this Nov 15, 2016
@a11n
Copy link
Owner

a11n commented Nov 15, 2016

First of all, many thanks for contributing to this project! I really appreciate this!

Your PR looks very nice. However, to keep consistency, when adding an option to "create-issue" we should provide the same option for "update-issue" as well. Could you please also add the option and implementation for "update-issue"?

Furthermore, at the moment there is no way to display the parent task. When we add a new option for attributes the user needs to be able to see this attribute when printing an issue.

Please take a look at template/issue.tmpland add the "parent task" information at a nice place.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4299865 on pedrobaracho:create-issue-parent-option into f38d3d8 on a11n:master.

Fixing description of --parent on update-issue.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4d26ada on pedrobaracho:create-issue-parent-option into f38d3d8 on a11n:master.

@pedropb
Copy link
Contributor Author

pedropb commented Nov 16, 2016

I'm working on it!

@pedropb
Copy link
Contributor Author

pedropb commented Nov 16, 2016

@a11n, what do you think that works better:

Redmine style

screen shot 2016-11-15 at 22 05 36

Property style

screen shot 2016-11-15 at 22 06 16

The parent issue is being shown similar to Redmine Web interface.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 99.541% when pulling 65078b9 on pedrobaracho:create-issue-parent-option into f38d3d8 on a11n:master.

Pedro Baracho added 2 commits November 15, 2016 23:15
Resolving parent issue on redmine.js- exports.getIssue() instead of
resolving on action.js handleIssues. This is a better solution given the
current package structure.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 94fed26 on pedrobaracho:create-issue-parent-option into f38d3d8 on a11n:master.

@pedropb
Copy link
Contributor Author

pedropb commented Nov 16, 2016

@a11n, the current branch listed on this PR implements the Redmine style template.

I'm done! You can merge it any time now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 27adacf on pedrobaracho:create-issue-parent-option into f38d3d8 on a11n:master.

@a11n
Copy link
Owner

a11n commented Apr 12, 2017

Hi @pedropb ,

I saw you started your own project based on this. Just want to tell you the I'm totally sorry that I never found the time to merge your nice PR. Since today it's on my TODO list, but unfortunately I never found the time to do it. SORRY!

I will deprecate this project and will notify committers to contribute to your project. Wish you good look with your CLI.

Thank you,
André

@a11n a11n closed this Apr 12, 2017
@a11n a11n mentioned this pull request Apr 12, 2017
@pedropb
Copy link
Contributor Author

pedropb commented Apr 12, 2017

No worries @a11n!

I thought you wanted to keep things separated. I understand your tool has a very specific goal which is to provide a CLI for redmine API.

My need was for an automation tool (like batch generation of issues, relations etc.). So I hacked your tool to add that functionality. It I totally think both tools can coexist and serve different purposes.

It is hard to find time for these hobby projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants