Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Contrast Article #382

Conversation

RachelRVasquez
Copy link
Contributor

This is the complete article from my gist on what color contrast is and
why we need it for web a11y

This is the complete article from my gist on what color contrast is and
why we need it for web a11y
@RachelRVasquez
Copy link
Contributor Author

For reference - this is linked to this article issue: #377 (comment)

@davatron5000
Copy link
Contributor

LGTM. I think this is ready to go. Does anyone else want to QA this? @joe-watkins @mpiotrowicz? Otherwise I'll pull the trigger in a few minutes.

I also think we can publish and if something broke, fix it after the fact.

@mpiotrowicz
Copy link
Contributor

good content, I like the color theory background! Would it be appropriate to flesh out more examples of why good color contrast is important? Eg when faced with screen glare, being outside on a sunny day, anyone who's stared at a screen at work all day, etc. (though that might be better content for the impairment article)

@joe-watkins
Copy link

Great work here.. I love it! Very readable :) To piggyback here I have a couple items:

Edit:
"There's a link to W3C's article at the end of this called "The Contrast Minimum" that explains how these ratios are calculated."

I'd love to see a meaningful link presented to the reader at this location rather than directing them to the end of the article.

Suggestion:
Also it may be worth pointing out that too much contrast can be an issue as well :) Users with Dyslexia can have trouble with Black on White: http://uxmovement.com/content/6-surprising-bad-practices-that-hurt-dyslexic-users/

@davatron5000
Copy link
Contributor

Cool. Let's merge this in and then iterations can be done in another issue and/or via the GitHub Editor.

davatron5000 added a commit that referenced this pull request Jan 5, 2016
@davatron5000 davatron5000 merged commit d3f6869 into a11yproject:gh-pages Jan 5, 2016
@davatron5000
Copy link
Contributor

👏 👏 👏 It's LIVE! http://a11yproject.com/posts/what-is-color-contrast/

Thanks @RachelRVasquez so much for hopping on board with this project. We all really appreciate the time, work, and new blood you've donated to this project. Look forward to the next one we get to merge in.

@RachelRVasquez
Copy link
Contributor Author

Yay thanks @davatron5000! I'm having a lot of fun and learning from you all as well.

@mpiotrowicz @joe-watkins These sound like great ideas for continuations. :-) I was having trouble deciding how deep to go into the subject so I tried to write it as a "primer" of sorts or an introduction. Then thinking maybe we can write other articles that go into depth of the different contrasts and visual impairments.

I like Joe's idea of editing the Contrast Minimum link so it's in the content versus at the end in "Further Reading". Wondering if maybe we can edit the description of the post so it's less repetitive as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants