Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive in REFCOUNT_FULL in recent 5.4.x #89

Closed
wants to merge 1 commit into from

Conversation

hlein
Copy link

@hlein hlein commented Sep 22, 2023

Extend VersionCheck to be able to take a three-tuple, x.y.z kernel version in order to properly recognise 5.4.208 as when this became the default behavior and thus CONFIG_REFCOUNT_FULL disappeared.

Closes: #88

Extend VersionCheck to be able to take a three-tuple, x.y.z kernel
version in order to properly recognise 5.4.208 as when this became
the default behavior and thus CONFIG_REFCOUNT_FULL disappeared.

Signed-off-by: Hank Leininger <hlein@korelogic.com>
Closes: a13xp0p0v#88
@a13xp0p0v
Copy link
Owner

@hlein, thanks for your pull request.

I think you need to adapt detect_kernel_version() to get the third number of the kernel version from the kconfig file.

One more aspect: you need to compare this number in the check() method of the VersionCheck class. Otherwise it will return wrong results.

@hlein
Copy link
Author

hlein commented Oct 4, 2023

@hlein, thanks for your pull request.

I think you need to adapt detect_kernel_version() to get the third number of the kernel version from the kconfig file.

Oh, you are probably right. I didn't have access to the box or config in question any more, so fabricated some data I was testing against; my tests must have been incomplete / accidentally-successful.

One more aspect: you need to compare this number in the check() method of the VersionCheck class. Otherwise it will return wrong results.

Oof, you're right. I think I had done things a different way before refactoring the self.ver_expected_print out, but then lost the check against self.ver_expected[2] when cleaning up. Ugh!

a13xp0p0v added a commit that referenced this pull request Mar 9, 2024
Example:
# Linux/x86_64 6.7.4-200.fc39.x86_64 Kernel Configuration

Refers to #88, #89, #97
a13xp0p0v added a commit that referenced this pull request Mar 9, 2024
a13xp0p0v added a commit that referenced this pull request Mar 9, 2024
a13xp0p0v added a commit that referenced this pull request Mar 9, 2024
a13xp0p0v added a commit that referenced this pull request Mar 9, 2024
This function should write 'self.state' anyway.

Refers to #88, #89, #97
a13xp0p0v added a commit that referenced this pull request Mar 9, 2024
a13xp0p0v added a commit that referenced this pull request Mar 9, 2024
@a13xp0p0v
Copy link
Owner

Closing. The feature is implemented.
Please see #88 (comment).

@a13xp0p0v a13xp0p0v closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on CONFIG_REFCOUNT_FULL in recent 5.4.x kernels
2 participants