-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
full host URL missing in *.json and *.tfl #1
Comments
Hi, thank you for using this and for the kind comments! I was able to reproduce the issue, it was definitely a bug and not a misconfiguration on your end. The path written in the index file were not relative to the index file so Tinfoil wasn't able to find them. I saw that you implemented a fix in your own fork, though I purposely left the "host" management outside of the app, in the fix I pushed the links should be working in any configuration, independent of how the app is deployed and how the user is acessing it. I tested it in my local network with Tinfoil 12 R13 and it works, if you want to test you can use the "latest" or "1.0.1" tag. Thanks! |
hi @a1ex4 thanks a lot for this :) . I'll give it a shot later today! |
Totally forgot to answer ! I've been using your fix ever since ! works great thanks :) |
Hi, thanks for this tool. Very useful.
I have an issue with the docker version and generating the urls for both the JSON and TFL files.
The content of the TFL is for example:
Which doesn't work with tinfoil if I add the following URL in it :
http://my_docker_host_server_ip:port
(I don't do port forwarding as I want to stay in the local network)
For the shop to work, I have to edit the shop.tfl and do some regex replacement(replacing the value
games
withhttp://my_docker_host_server_ip:port
:Obviously this seems overkill, and it only works for 5 min until the cronjob overwrites the modifications.
Is this an issue, or a misunderstanding from my behalf of the configuration to do?
I looked at the python script and couldn't see where the host url would be added to the URL.
Cheers!
The text was updated successfully, but these errors were encountered: