Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add port_numbers API #42

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Add port_numbers API #42

merged 1 commit into from
Oct 17, 2020

Conversation

serpilliere
Copy link
Contributor

Add port_numbers API.
The result of #41 maybe taken into account before.

a1ien
a1ien reviewed Oct 6, 2020
View reviewed changes
src/device.rs Outdated Show resolved Hide resolved
@serpilliere
Copy link
Contributor Author

I have updated the fix

a1ien
a1ien reviewed Oct 16, 2020
View reviewed changes
src/device.rs Outdated Show resolved Hide resolved
@serpilliere
Copy link
Contributor Author

Hi!
I think I took all your comments into account.

@a1ien a1ien merged commit 62e814e into a1ien:master Oct 17, 2020
@a1ien
Copy link
Owner

a1ien commented Oct 17, 2020

Thanks!

@serpilliere
Copy link
Contributor Author

Thanks to you @a1ien !

@serpilliere serpilliere deleted the get_port_numbers branch October 17, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a1ien a1ien a1ien left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@serpilliere @a1ien