Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of whitespace on charts, make elements bolder, add "streaming mode" toggle for overlaying charts using Chroma key in OBS #87

Merged
merged 19 commits into from
May 19, 2021

Conversation

strazto
Copy link
Contributor

@strazto strazto commented May 1, 2021

Resolves #88
Resolves #89

Squash Requested I'm not a C# programmer & have minimal experience with .NET and WPF, so many of my commits are fixups / trying to understand idioms & also match the patterns already seen in the project.

This PR addresses graph styling in two areas

  1. Improves whitespace usage & increases font size of certain chart labels / titles
  2. Adding a "Streaming Mode" toggle that sets:
    • chart FG colours to white (255, 255, 255), and
    • BG colours to green (0, 192, 0)
      The purpose of this is to allow effective chroma-keying of the green background for the live charts out, using streaming/recording software (Eg, OBS), for the purpose of either streaming/recording instructional videos, or watching back recorded real gameplay to understand what parts of your curve are being used in real-game situations.

Find screenshots below - I'd share a Kovaaks recording but I don't want to embarass myself.

Chart Style Improvements

Before

before screenshot

After

Re-styled chart elements

Streaming Mode

RawAccel with "Streaming Mode" Enabled

streaming mode enabled

OBS Output After Chroma-Key

streaming mode in OBS

OBS Chroma Key Settings

Chroma Key Settings For Achieving Effect

Copy link
Collaborator

@JacobPalecki JacobPalecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, these changes look great. I'm going to do a more in-depth review later but nothing stands out as wrong at a glance.

@strazto
Copy link
Contributor Author

strazto commented May 5, 2021

@JacobPalecki - I haven't tested this out yet, but it's possible that Chroma-keying might work effectively if the key is set to be dark/black in OBS.

I'll have to confirm that's true, but if that's the case, I might ask that we delay merging this & I will change "Streaming Mode" to "Dark Mode" & expand the colour changes to theme the whole window dark.

@JacobPalecki
Copy link
Collaborator

@JacobPalecki - I haven't tested this out yet, but it's possible that Chroma-keying might work effectively if the key is set to be dark/black in OBS.

I'll have to confirm that's true, but if that's the case, I might ask that we delay merging this & I will change "Streaming Mode" to "Dark Mode" & expand the colour changes to theme the whole window dark.

That's fine. I've reviewed the code changes and they are good. I've never set up a streaming overlay myself so I'm not exactly sure about any subtleties around the chroma-key but am happy for a background color change to bring some utility there. A dark mode would be useful to users regardless of chroma-key so if you wanted to add a dark mode and streaming mode that would be cool as well. Totally up to you

@strazto
Copy link
Contributor Author

strazto commented May 6, 2021

Actually, I won't have time to have a look at this properly for a bit - go aheard & squash merge it, and later on I can either add dark mode, or change it to dark mode :)

Thanks for the review - Nice to get a review w/ no change requests :)

@JacobPalecki JacobPalecki merged commit f88751f into a1xd:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants