Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default window_type for power_spectral_density does not work #156

Open
DriesAllaerts opened this issue Nov 10, 2022 · 0 comments
Open

Default window_type for power_spectral_density does not work #156

DriesAllaerts opened this issue Nov 10, 2022 · 0 comments

Comments

@DriesAllaerts
Copy link
Member

In helper_functions.py>power_spectral_density(), the default window_type is 'hanning'. However, this window_type raises a ValueError "unknown window type". Accepted window types are either "hamming" or "hann". The term "hanning" window is a common mistake but it is not the official name and hence not accepted by the welch method.

Solution: Change "hanning" to "hann".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant