Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENHANCE: Add Docker file for Jupyter support #248

Merged
merged 2 commits into from
Nov 26, 2020
Merged

ENHANCE: Add Docker file for Jupyter support #248

merged 2 commits into from
Nov 26, 2020

Conversation

ScottyB
Copy link
Contributor

@ScottyB ScottyB commented Nov 15, 2020

  • Adds a Docker file to the generated Surround projects and simplifies to doit commands for interacting with the notebook.
  • Updated the generated notebook to load data from a runner and load the config file.

AkshatBajaj
AkshatBajaj suggested changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@AkshatBajaj AkshatBajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web Dodo.py is still using the old tasks, that needs to be updated as well

templates/new/dodo.py.txt
'task_dep': ['build'],
'params': PARAMS
}}

def task_jupyter():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this for web version as well

@AkshatBajaj
Copy link
Contributor

/test

AkshatBajaj
AkshatBajaj reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@AkshatBajaj AkshatBajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this warning for tornado version, could be worth investigating

Screen Shot 2020-11-26 at 3 12 33 pm

AkshatBajaj
AkshatBajaj approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@AkshatBajaj AkshatBajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on slack, tornado issue will be fixed on a separate PR

@AkshatBajaj AkshatBajaj merged commit 3dfa6bc into a2i2:master Nov 26, 2020
@AkshatBajaj AkshatBajaj mentioned this pull request Dec 9, 2020
Merged
@ScottyB ScottyB deleted the feature/simpler-jupyter branch March 9, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshatBajaj AkshatBajaj AkshatBajaj approved these changes

Assignees

@AkshatBajaj AkshatBajaj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ScottyB @AkshatBajaj