Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move existing flavortext to flavortext module #95

Open
JohnathonNow opened this issue Oct 11, 2019 · 2 comments
Open

Move existing flavortext to flavortext module #95

JohnathonNow opened this issue Oct 11, 2019 · 2 comments
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@JohnathonNow
Copy link
Collaborator

There are many pieces of dialog throughout the code that should be moved to the flavortext module. In addition to keeping things organized, it also makes potential translation easier if anyone eventually ever cares about that.

@JohnathonNow JohnathonNow added good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed labels Oct 11, 2019
@adinalini
Copy link
Contributor

Can you elaborate with an example, I am a little confused, would love to take this up

@JohnathonNow
Copy link
Collaborator Author

Right now we have user displayed strings throughout the entire codebase, such as
here. I think it would be better for that line to be changed to

add_action(FT_HAG_SUMMON_SNEK);

and then a line added to flavortext.h that says:

#DEFINE FT_HAG_SUMMON_SNEK ("The old hag summons a dangerous snek!")

with this done to all displayed strings.
Formatted strings are a little more tricky, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants