Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added RNG files #110

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Added RNG files #110

merged 2 commits into from
Oct 16, 2019

Conversation

Apoorv-Gaurav-Agarwal
Copy link
Contributor

These files haven't been linked with the rest of the code. The values max and droprate which will be passed were not known

JohnathonNow
JohnathonNow requested changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@JohnathonNow JohnathonNow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

If you could just note these minor review notes I'd appreciate it. If you don't have time to make the changes then I can merge to the dev branch before merging to master.

src/rng.c Outdated Show resolved Hide resolved
src/rng.c Show resolved Hide resolved
@JohnathonNow JohnathonNow changed the base branch from master to dev October 16, 2019 05:21
@JohnathonNow JohnathonNow merged commit deb8ff6 into a3qz:dev Oct 16, 2019
@JohnathonNow
Copy link
Collaborator

Thanks!

@JohnathonNow JohnathonNow mentioned this pull request Oct 17, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnathonNow JohnathonNow JohnathonNow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Apoorv-Gaurav-Agarwal @JohnathonNow