Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.8.0 #46

Merged
merged 1 commit into from
Dec 24, 2020
Merged

release: v1.8.0 #46

merged 1 commit into from
Dec 24, 2020

Conversation

newt-sc
Copy link
Collaborator

@newt-sc newt-sc commented Dec 24, 2020

No description provided.

@newt-sc newt-sc self-assigned this Dec 24, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@newt-sc newt-sc merged commit cd4a674 into master Dec 24, 2020
@newt-sc newt-sc deleted the develop branch December 24, 2020 05:02
@farmaher
Copy link

Hi Buddy - Subscene still not working, Please could you fix it it is the top subtitle service for non-English users.

@newt-sc
Copy link
Collaborator Author

newt-sc commented Dec 25, 2020

@farmaher The tests are passing and even done manual testing for English and Non-English results for Movies and TVShows. It seems to work. However, there were two times that I received a 503 (Service Unavailable) response from Subscene, so I presume the Subscene website is having issues loading occasionally. Will add a simple retry logic for such cases.

@newt-sc
Copy link
Collaborator Author

newt-sc commented Dec 26, 2020

I see there is another issue for Subscene, related to the TVShow searching and the meta for the season year, which is used for matching. Will look into it. Thanks for the report.

@farmaher
Copy link

I tried V2.0 in search for Persian subtitles but no results on Subscene again. Please check these out HERE & HERE. These are the settings in KODI, HERE & HERE

@newt-sc
Copy link
Collaborator Author

newt-sc commented Dec 26, 2020

@farmaher This was a specific Persian language issue. Fixed in v2.1.0.

@farmaher
Copy link

Many thanks for fixing it, will give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants