Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial version refactoring #30

Closed
7 tasks done
a5kin opened this issue Jan 2, 2018 · 1 comment
Closed
7 tasks done

Initial version refactoring #30

a5kin opened this issue Jan 2, 2018 · 1 comment
Assignees
@a5kin
Labels
maintenance
Milestone
v0.1.1

Comments

@a5kin
Copy link
Owner

a5kin commented Jan 2, 2018 •
edited

A collection of random issues coming to mind during code inspection.

  • Add abstract methods to Lattice base class
  • Add abstract methods to Neighborhood base class
  • Split Border into 2 abstract casses
  • Remove unused Property.declare_once() argument
  • Check the correctness of OrthogonalNeighborhood.neighbor_state
  • Move Lattice.is_off_board_code to Border
  • Merge core.base.topology.mixins and core.base.mixins
@a5kin a5kin self-assigned this Jan 2, 2018
a5kin added a commit that referenced this issue Jan 6, 2018
@a5kin
Remove unused Property.declare_once() argument (#30)
393322a
@a5kin a5kin added this to the v0.1.1 milestone May 9, 2018
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Add pylint config (#30)
aee9b52
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Add pylint run script (#30)
b3de428
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Fix pylint issues in tests.seeds.test_random (#30)
314c267
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Fix pylint issues in tests.seeds.test_patterns (#30)
2aa2c70
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Rename pylint config (#30)
1586d19
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Fix pylint issues in tests.bridge.test_base (#30)
63262a3
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Fix pylint issues in tests.performance (#30)
5cb98de
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Fix pylint issues in tests.core.test_variables (#30)
95fe16c
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Make some private properties public (#30)
94cecde
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Fix pylint issues in tests.core.test_properties (#30)
b4430ed
a5kin added a commit that referenced this issue Jun 15, 2018
@a5kin
Fix pylint issues in tests.core.test_base (#30)
ac96f57
a5kin added a commit that referenced this issue Jun 16, 2018
@a5kin
Fix pylint issues in tests.core.test_mixins (#30)
922d675
a5kin added a commit that referenced this issue Jun 16, 2018
@a5kin
Add pylint config to MANIFEST.in (#30)
d37e23b
a5kin added a commit that referenced this issue Jun 16, 2018
@a5kin
Fix pylint issues in setup script (#30)
955395e
a5kin added a commit that referenced this issue Jun 25, 2018
@a5kin
Rename LocalRandom streams (#30)
f63ca47
a5kin added a commit that referenced this issue Jun 25, 2018
@a5kin
Fix pylint issues in seeds.patterns (#30)
b7e1c86
a5kin added a commit that referenced this issue Jun 25, 2018
@a5kin
Fix pylint issues in bridge.base (#30)
b083c6d
a5kin added a commit that referenced this issue Jun 25, 2018
@a5kin
Add sphinx config to pylint ignore (#30)
1ac8a5a
a5kin added a commit that referenced this issue Jun 26, 2018
@a5kin
Fix pylint issues in core.base (#30)
c094656
a5kin added a commit that referenced this issue Jun 26, 2018
@a5kin
Add properties getter to ContainerProperty (#30)
db4be0e
a5kin added a commit that referenced this issue Jun 26, 2018
@a5kin
Fix pylint issues in core.base (#30)
47c35b8
a5kin added a commit that referenced this issue Jun 26, 2018
@a5kin
Add test for unset viewport (#30)
5f274ad
a5kin added a commit that referenced this issue Jun 26, 2018
@a5kin
Fix pylint issues in core.variables (#30)
50dfa51
a5kin added a commit that referenced this issue Jun 26, 2018
@a5kin
Make bsca property public (#30)
bf3f727
a5kin added a commit that referenced this issue Jun 26, 2018
@a5kin
Fix pylint issues in core.variables (#30)
7fe4b79
a5kin added a commit that referenced this issue Jun 26, 2018
@a5kin
Fix pylint issues in core.renderers (#30)
16945e9
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in core.topology.neighborhood (#30)
2b27b9a
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in core.topology.border (#30)
4c2c0bb
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in core.topology.lattice (#30)
3da6d6b
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in tests.core.test_properties (#30)
289f6da
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in core.properties (#30)
a1234cd
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in core.color_effects (#30)
620df0f
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in core.mixins (#30)
d96d75c
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in examples.shifting_sands (#30)
8ee3543
a5kin added a commit that referenced this issue Jun 27, 2018
@a5kin
Fix pylint issues in examples.game_of_life (#30)
2bbdb86
a5kin added a commit that referenced this issue Jun 28, 2018
@a5kin
Add numpy/moire to pylint ignore (#30)
e77d480
a5kin added a commit that referenced this issue Jun 28, 2018
@a5kin
Add pycuda/cached_property to pylint ignore (#30)
e8d0675
a5kin added a commit that referenced this issue Jul 4, 2018
@a5kin
Move GPU stuff to separate class (#30)
2e30dfc
a5kin added a commit that referenced this issue Jul 4, 2018
@a5kin
Decompose BSCA class creation into smaller methods (#30)
2375cac
a5kin added a commit that referenced this issue Jul 5, 2018
@a5kin
Fix typos in docstrings (#30)
28e4d8b
a5kin added a commit that referenced this issue Jul 5, 2018
@a5kin
Move core.topology.mixins to core.mixins (#30)
7cd056e
a5kin added a commit that referenced this issue Jul 5, 2018
@a5kin
Increase max attributes limit for pylint (#30)
7d0d521
@a5kin
Copy link
Owner Author

a5kin commented Jul 22, 2018

We've done a good job in refactoring, fixing most of pylint issues and making object model more consistent. Only 2 pylint categories were disabled in the process: 1) no-member, since it can not detect CellularAutomaton members generated by the metaclass, 2) too-few-public-methods, because experiment classes are holding "data" only, that's allowing them to be easily inherited.

@a5kin a5kin closed this as completed Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a5kin a5kin

Labels
maintenance
Projects
None yet
Milestone
v0.1.1
Development

No branches or pull requests
1 participant
@a5kin