-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input[type="range"] "change" event firing differs from native implementations #297
Comments
Yes, you should bind to the original element. The change event is triggered if a a) value was changed by the user and b) commit action (mouseup or keyup in case of a range input) or a activation/blur behavior happened. The behavior in FF is correct, while the behavior in Chrome is busted. Actually Chrome-Dev doesn't want to change this.
Is this just a question or do you think there is something wrong with webshims implementation. Please re-open, if there is a bug. |
I understand now: webshims implements Thanks for the library. |
The input event is already fixed by webshims in IE10/11. I have just added some code to fix the change event in IE10/11, chrome and Safari. The fix is currently turned off by default. You can turn it on by setting the fixRangeChange to true:
|
On recent versions of Webkit and Firefox the change event fires after every step of
input[type="range"]
. The webshim polyfill change seems to fire on keyup/mouseup.My original "change" method for
input[type="range"]
was binded to keyup/mouseup for performance reasons.From what I've seen in
range-ui.js
, I assume my listeners stay on the original element and the change event is triggered when the polyfill changes the original's value on each step. Is this correct?The text was updated successfully, but these errors were encountered: