executeScalarList should use converters

[aaberg]

executeScalarList should use registered converters.

[aldenquimby]

I have a possible suggestion here.

Maybe you could simplify the interface by having executeAndFetch and executeAndFetchFirst handle cases where someone is asking for a scalar. That way you wouldn't need a separate method to handle scalars, and users wouldn't need to think about which method to call depending on their type - they would just always call the generic execute and fetch methods.

For backwards compatibility, you could keep executeScalar and executeScalarList and have them just call executeAndFetch.

Looking at the existing code, I think this could work by checking if PojoMetadata.propertySetters is empty. I would be happy to do this on a branch and show you what I mean if this is confusing.

[aaberg]

That is an interesting idea!

The only consequence I can think of, that might be a problem, is if there is a property on the class with the same name as the column in the database. In this case, sql2o will try to convert that property instead of using a converter on the class itself.

But if we can find a good way of handling this, I am very positive to the idea. What do you think?

[aldenquimby]

Yeah good point. I think I have an idea for how it could work.

I'll try it out and submit a pull request for you to review if I can get it working

[aldenquimby]

#46