Use a constructor to initialize SQLCompiler

When dialects are in separate packages, they better not use unkeyed initialization of SQLCompiler.
aacanakin · Dec 20, 2016 · 7fbe2ae · 7fbe2ae
1 parent 9a31a5e
commit 7fbe2ae
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/compiler.go b/compiler.go
@@ -55,6 +55,11 @@ type Compiler interface {
 	VisitWhere(*CompilerContext, WhereClause) string
 }
 
+// NewSQLCompiler returns a new SQLCompiler
+func NewSQLCompiler(dialect Dialect) SQLCompiler {
+	return SQLCompiler{Dialect: dialect}
+}
+
 // SQLCompiler aims to provide a SQL ANSI-92 implementation of Compiler
 type SQLCompiler struct {
 	Dialect Dialect

diff --git a/dialect_mysql.go b/dialect_mysql.go
@@ -70,7 +70,7 @@ func (d *MysqlDialect) Driver() string {
 
 // GetCompiler returns a MysqlCompiler
 func (d *MysqlDialect) GetCompiler() Compiler {
-	return MysqlCompiler{SQLCompiler{d}}
+	return MysqlCompiler{NewSQLCompiler(d)}
 }
 
 // MysqlCompiler is a SQLCompiler specialised for Mysql

diff --git a/dialect_postgres.go b/dialect_postgres.go
@@ -77,7 +77,7 @@ func (d *PostgresDialect) Driver() string {
 
 // GetCompiler returns a PostgresCompiler
 func (d *PostgresDialect) GetCompiler() Compiler {
-	return PostgresCompiler{SQLCompiler{d}}
+	return PostgresCompiler{NewSQLCompiler(d)}
 }
 
 // PostgresCompiler is a SQLCompiler specialised for PostgreSQL

diff --git a/dialect_sqlite.go b/dialect_sqlite.go
@@ -69,7 +69,7 @@ func (d *SqliteDialect) Driver() string {
 
 // GetCompiler returns a SqliteCompiler
 func (d *SqliteDialect) GetCompiler() Compiler {
-	return SqliteCompiler{SQLCompiler{d}}
+	return SqliteCompiler{NewSQLCompiler(d)}
 }
 
 // SqliteCompiler is a SQLCompiler specialised for Sqlite