Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection nodes to have individual mode selection #80

Merged
merged 6 commits into from
Dec 8, 2019

Conversation

8176135
Copy link

@8176135 8176135 commented Dec 7, 2019

Closes #79

Adds a new type: SelectionType

By default selection nodes have no selection type specified, and use the current behavior of using the edit mode selection type.

However it is now possible to manually override the selection mode directly on the node, or plug in something to the selection type socket.

Also added icons to the EditMode node.

PS: I can also add the socket to the EditMode node as well, instead of it being just buttons. But this might break current node setups?

Copy link
Owner

@aachman98 aachman98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
I'll open an issue for the custom-layout-draw-function-for-sockets approach

@aachman98 aachman98 merged commit 02504a3 into aachman98:master Dec 8, 2019
@aachman98 aachman98 added the enhancement Request for new feature label Dec 8, 2019
@aachman98
Copy link
Owner

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection nodes should have individual mode selection
2 participants