Webpack 4 support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gpoitch thanks for the work I'll try to take a look at this later tonight. 👍 |
ooflorent
approved these changes
Mar 2, 2018
index.js
Outdated
| compiler.plugin('compilation', (compilation) => { | ||
| compilation.plugin('optimize-modules', (modules) => { | ||
| compiler.hooks.compilation.tap('circular-dependency-plugin', (compilation) => { | ||
| compilation.hooks.optimizeModules.tap('circular-dependency-plugin', (modules) => { |
There was a problem hiding this comment.
CircularDependencyPlugin would be better
gpoitch
force-pushed
the
gpoitch/webpack4
branch
from
fdf52af
to
b8a0061
Compare
gpoitch
force-pushed
the
gpoitch/webpack4
branch
from
b8a0061
to
f5d656e
Compare
|
@aackerman Pinging, just in case this fell through your todo list 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking internal plugin changes, so I bumped this plugin's major version and added webpack 4 peerDependency.
Closes #32