Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code restructuring: properly port Braille Extender to Python 3, remove Python 2 idioms and facilities #69

Closed
josephsl opened this issue Jul 16, 2020 · 2 comments

Comments

@josephsl
Copy link
Contributor

Hi,

A high priority blocker for #68

Before linting can proceed, it is important to port Braille Extender to Python 3. This is because add-on manifest says NVDA 2019.3 is the minimum supported version, and NVDA Core expects Python 3.7 or later.

The following will be done:

  • Remove Python 2 checks
  • Remove unicode literals import directive
  • Many more

Thanks.

josephsl added a commit to josephsl/BrailleExtender that referenced this issue Jul 16, 2020
As Braille Extender supports NVDA 2019.3 or later (according to manifest), there is no need to keep isPy3 check variable in the add-on anymore, along with Python 2 specific code for imports and such.
josephsl added a commit to josephsl/BrailleExtender that referenced this issue Jul 16, 2020
As Python 3 demands Unicode strings by default (unless prefixed by b for bytes), remove unnecessary __futre__.unicode_literals import.
@aaclause
Copy link
Owner

Hi @josephsl,

  • Remove Python 2 checks
  • Remove unicode literals import directive

I think all these are done.

  • Many more

Could you elaborate on this? Perhaps it's better to close this issue and open others.

Thanks

@josephsl
Copy link
Contributor Author

josephsl commented Nov 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants