Disable SingleLogoutService for SP

[JoeyHoutenbos]

Hi,

I don't want to expose a single-logout service, so I expected to do something like this in the "config/saml2_settings.php":

'sp' => array(
    ...
    'singleLogoutService' => false,
),

But this still sets up the service in the Saml2ServiceProvider@register. When I remove/comment out this part it is working:

if (empty($config['sp']['singleLogoutService']['url'])) {
    $config['sp']['singleLogoutService']['url'] = URL::route('saml_sls');
}

Why isn't this supported? Maybe it's better to check if the singleLogoutService even exists and if it does if the value isn't equal to false before inserting it.

@aacotroneo what do you think about it?

[aacotroneo]

yep, that could be a good improvement. It's not supported because no one needed/cared about it, but it does make sense. Something like this to remain the most backwards compatible we can?

 if (!empty($config['sp']['singleLogoutService']) && 
     empty($config['sp']['singleLogoutService']['url']){
            $config['sp']['singleLogoutService']['url'] = URL::route('saml_sls');
 }

[JoeyHoutenbos]

I agree with you that would be the most backwards compatible solution.
This means in the settings the whole singleLogoutService part can be removed and it won't be added to the metadata.

Is this something you can include soon?

[aacotroneo]

I don't have an environment to test that at the time being. If you want to make a PR with that change and check it's working, we can merge it and include it in the next release. 2017-01-18 12:12 GMT-03:00 Joey <notifications@github.com>:

…

I agree with you that would be the most backwards compatible solution. This means in the settings the whole singleLogoutService part can be removed and it won't be added to the metadata. Is this something you can include soon? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKFpc1m-vl_F2y9JvnBS3MN1dlf4sEh4ks5rTivWgaJpZM4Lm6pJ> .

[JoeyHoutenbos]

I made a PR #69. Please check it out and include in next release.