directly call the UrlGenerator binding instead of using the helper #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returns it - fix for Laravel 5.1
|
Note: I don't have time to test this on a 5.1 install at the moment, so someone should manually verify this before merging it in! |
aacotroneo
added a commit
that referenced
this pull request
Mar 21, 2016
directly call the UrlGenerator binding instead of using the helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently only Laravel 5.2 returns the UrlGenerator from the url helper when you call it with no arguments, this bypasses the helper and fixes that.
It looks like Taylor is deemphasising Facades, so we should stick with the helpers or app bindings where possible, and if in the future we drop support for 5.1 this can be removed in favour of calling
url()->fullagain.Fixes #31 and #32.