ticket: 5394

version_fixed: 1.6.1

pull up r19065 from trunk

 r19065@cathode-dark-space:  jaltman | 2007-01-18 06:35:33 -0500
 ticket: 5394
 tags: pullup
 
   	sendto_kdc.c: use of a variable index into a dynamically 
 	allocated array to determine the sizeof() an object makes
 	it unclear what type of object is involved.  It also requires
 	a runtime check instead of a compile time replacement.  
 	Not to mention that it could lead to the evaluation of an 
 	uninitialized variable as was done in this case.  Replace
 	sizeof(array index variable) with sizeof(type). 
 
 	memset() the correct data structure.  
 
 



git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19111 dc483132-0cff-0310-8789-dd5450dbe970

src/lib/krb5/os/sendto_kdc.c

@@ -1127,15 +1127,15 @@ krb5int_sendto (krb5_context context, const krb5_data *message,
 	return ENOMEM;
     }
 
-    memset(conns, 0, n_conns * sizeof(conns[i]));
+    memset(conns, 0, n_conns * sizeof(struct conn_state));
 
     if (callback_info) {
 	callback_data = malloc(n_conns * sizeof(krb5_data));
 	if (callback_data == NULL) {
 	    return ENOMEM;
 	}
 
-	memset(conns, 0, n_conns * sizeof(callback_data[i]));
+	memset(callback_data, 0, n_conns * sizeof(krb5_data));
     }
 
     for (i = 0; i < n_conns; i++) {