Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JWT Auth Token #11

Closed
rohitpawar2811 opened this issue Dec 13, 2023 · 3 comments
Closed

Support for JWT Auth Token #11

rohitpawar2811 opened this issue Dec 13, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@rohitpawar2811
Copy link
Contributor

Hi,

I'm reaching out regarding an issue with sqlalchemy-solr. Currently, only Basic-Auth is supported . The request is for adding Jwt Auth Token support when connecting to Solr.

Current connection:
solr://username:XXXXXXXXXX@host:8983/solr/local-enterpriseSearch

Desired connection:
solr://172.20.20.244:8983/solr/local-enterpriseSearch?token=13224212....

Thanks!

@rohitpawar2811 rohitpawar2811 changed the title JWT Auth Token Support Support for JWT Auth Token Dec 13, 2023
@aadel aadel added the enhancement New feature or request label Dec 13, 2023
@rohitpawar2811
Copy link
Contributor Author

@aadel
Here is the PR for the enhancement: https://github.com/aadel/sqlalchemy-solr/pull/15/files
Please review the changes, and if you find anything incorrect, kindly let me know.
Thank you.

@aadel
Copy link
Owner

aadel commented Dec 27, 2023

Hi @rohitpawar2811 Thank you for your contribution! SolrTableReflection class responsibility is to deduce and map metadata from Solr index given the resultset and the query. The class implements a simple caching mechanism for which the depicted loop above represents a cache miss.

At this time, aliases and cross join use cases are not supported. However, I have added a new issue #16 for handling aliases.

@rohitpawar2811
Copy link
Contributor Author

Closing this enchancement issue as its completed in below
MR: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants