Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TMCS stopping, 1 of ... #248

Merged
merged 22 commits into from
Jan 19, 2023
Merged

TMCS stopping, 1 of ... #248

merged 22 commits into from
Jan 19, 2023

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Jan 17, 2023 •
edited
Loading

Description

This PR is a first step towards implementing general stopping criteria

Changes

  • Adds operations on ValuationResults and (Valuation)Status
  • Renames ValuationStatus to Status (since it's independent of the algorithm)
  • Moves a couple of classes around to avoid circular imports
  • Does some cleanup

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@mdbenito mdbenito added the enhancement New feature or request label Jan 17, 2023
@mdbenito mdbenito self-assigned this Jan 17, 2023
@mdbenito mdbenito marked this pull request as draft January 17, 2023 21:34
@mdbenito mdbenito changed the title Stopping criteria and related changes TMCS stopping, 1 of ... Jan 17, 2023
@mdbenito mdbenito marked this pull request as ready for review January 18, 2023 22:13
@mdbenito
Merge branch 'develop' into feature/ghorbani-stopping
17fc6e4 
# Conflicts:
#	CHANGELOG.md
#	tests/value/conftest.py
#	tests/value/least_core/conftest.py
@mdbenito
De-fluffing
191ba21
AnesBenmerzoug
AnesBenmerzoug approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@AnesBenmerzoug AnesBenmerzoug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I left 2 comments but feel free to ignore them for now.

@mdbenito mdbenito merged commit ade7204 into develop Jan 19, 2023
@mdbenito mdbenito deleted the feature/ghorbani-stopping branch January 19, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnesBenmerzoug AnesBenmerzoug AnesBenmerzoug approved these changes

Assignees

@mdbenito mdbenito

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdbenito @AnesBenmerzoug