Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toy Shapley games #341

Merged
merged 34 commits into from
Jan 23, 2024
Merged

Toy Shapley games #341

merged 34 commits into from
Jan 23, 2024

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Apr 11, 2023 •
edited by AnesBenmerzoug
Loading

Description

This PR closes #226

Changes

  • Added a new module pydvl.value.shapley.games with implementations of all games as described in Castro et al 2009
  • Moved toy games in pydvl.utils.utility to new games module.
  • Removed gloves game class in favour of shoes game class.
  • Updated least core tests.
  • Replaced use of analytical shapley fixture by toy game fixtures.
  • Fixed bug with skipping converged values in semivalues.
  • Found bug with semivalues batching and parallelization that makes the results not reproducible.
  • Added test for ValuationResults' update method's order invariance.

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@mdbenito mdbenito added the help-wanted Extra attention is needed label Aug 26, 2023
@mdbenito mdbenito mentioned this pull request Dec 14, 2023
Open
5 tasks
@mdbenito mdbenito added this to the v0.10.0 milestone Dec 14, 2023
@AnesBenmerzoug AnesBenmerzoug modified the milestones: v0.10.0, v0.9.0 Jan 14, 2024
@AnesBenmerzoug AnesBenmerzoug self-assigned this Jan 14, 2024
@AnesBenmerzoug
Merge branch 'develop' into feature/shapley-games
f3ab6e3
@AnesBenmerzoug
Move games.py module out of shapley package
cdbd6b3
@AnesBenmerzoug
Reimplement games as classes
0635210
@AnesBenmerzoug
Create DummyGameDataset class to fix dataset handling in games, sligh…
6475639 
…tly change Game interface
@AnesBenmerzoug
Implement Miner and Gloves games using new Game interface
865c378
@AnesBenmerzoug
Delete GlovesGame in favor of ShoesGame, improve Game classes' docstr…
aa0931a 
…ings
@AnesBenmerzoug
Improve games docstrings
c38ebe9
@AnesBenmerzoug
Fix shapley value computation for shoes game
79cdd4b
@AnesBenmerzoug
Add tests for exact shapley methods using toy games
c963ee8
@AnesBenmerzoug
Add test_game for montecarlo shapley methods
3074013
@AnesBenmerzoug
Fix type annotation issues
5a4bc04
@AnesBenmerzoug
Merge branch 'develop' into feature/shapley-games
ad1158e
@AnesBenmerzoug
Fix parameters in test
56502da
@AnesBenmerzoug
Delete test_linear_montecarlo_shapley
329ed80
@AnesBenmerzoug
Replace analytic and linear montecarlo truncated tests with games
7c3227f
@AnesBenmerzoug
Fix counting number of converged values
762a198
@AnesBenmerzoug AnesBenmerzoug marked this pull request as ready for review January 22, 2024 10:46
@AnesBenmerzoug
Copy link
Collaborator

@mdbenito I cannot put you as reviewer because you created the PR.

@AnesBenmerzoug AnesBenmerzoug mentioned this pull request Jan 22, 2024
Open
AnesBenmerzoug
AnesBenmerzoug previously approved these changes Jan 22, 2024
View reviewed changes
@AnesBenmerzoug AnesBenmerzoug merged commit f2f7466 into develop Jan 23, 2024
@mdbenito mdbenito deleted the feature/shapley-games branch February 13, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnesBenmerzoug AnesBenmerzoug AnesBenmerzoug left review comments

Assignees

@AnesBenmerzoug AnesBenmerzoug

Labels
help-wanted Extra attention is needed
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Implement all toy examples (games) in Castro2017
2 participants
@mdbenito @AnesBenmerzoug