Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to install dev requirements with python 3.10 #382

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Fix failure to install dev requirements with python 3.10 #382

merged 5 commits into from
Jul 25, 2023

Conversation

AnesBenmerzoug
Copy link
Collaborator

@AnesBenmerzoug AnesBenmerzoug commented Jul 25, 2023 •
edited
Loading

Description

This PR closes #381

Changes

  • Bumps pytest-docker to 2.0.0
  • Removes docker_compose_command fixture

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@AnesBenmerzoug AnesBenmerzoug self-assigned this Jul 25, 2023
Xuzzo
Xuzzo approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@Xuzzo Xuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for prompt fix

@AnesBenmerzoug AnesBenmerzoug merged commit 16d67e5 into develop Jul 25, 2023
0 of 2 checks passed
@mdbenito mdbenito deleted the 381-failure-to-install-pyyaml-with-python-310 branch August 11, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuzzo Xuzzo Xuzzo approved these changes

@schroedk schroedk Awaiting requested review from schroedk

Assignees

@AnesBenmerzoug AnesBenmerzoug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to install pyyaml with Python 3.10
2 participants
@AnesBenmerzoug @Xuzzo