Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parallel module outside utils #421

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Move parallel module outside utils #421

merged 2 commits into from
Sep 6, 2023

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Sep 3, 2023

Description

This PR refactors the parallel module. We should probably do the same with half of utils

Changes

  • moves utils.parallel out of utils
  • moves ParallelConfig into pydvl.parallel.config.
  • importing from pydvl.utils and from pydvl.utils.parallel still works and displays a deprecation warning. If we merge this I'll create an issue to remove the old module on that release

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@mdbenito mdbenito merged commit fb5375f into develop Sep 6, 2023
12 checks passed
@mdbenito mdbenito deleted the refactor/parallel branch September 6, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants