Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data_names in ValuationResult.zeros() #443

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Fix data_names in ValuationResult.zeros() #443

merged 5 commits into from
Oct 5, 2023

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Oct 2, 2023

Description

This PR fixes initialization of data names using ValuationResult.zeros()

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@mdbenito mdbenito marked this pull request as ready for review October 2, 2023 07:54
@mdbenito mdbenito self-assigned this Oct 2, 2023
@mdbenito mdbenito added the bug Something isn't working label Oct 2, 2023
@mdbenito mdbenito merged commit 15c67ec into develop Oct 5, 2023
0 of 6 checks passed
@mdbenito mdbenito deleted the fix/value-init branch October 5, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdbenito mdbenito

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdbenito