Improve logging for influence modules #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of generators and optional int paramter, adapt docstrings
…se the logger of the module pydvl.utils.progress
schroedk
changed the title
janosg
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #575 closes #576 closes #577
Changes
log_duration, to log depending on the module's loggerLissaInfluenceandCgInfluence, add parameterwarn_on_max_iterationtodisplay a warning if desired toelrance is not achieved within
maxitertqdmprogress bars to the computation ofLazyChunkSequenceandNestedLazyChunkSequence(which are returned from calls toSequentialInfluenceCalculator)Checklist
Wrote Unit tests (if necessary)If notebooks were added/changed, added boilerplate cells are tagged with"tags": ["hide"]or"tags": ["hide-input"]