Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing move to model device for EkfacInfluence implementation #570

Merged
merged 4 commits into from
May 3, 2024

Conversation

schroedk
Copy link
Collaborator

@schroedk schroedk commented May 2, 2024

Description

This PR closes #569

Changes

  • Add missing move of tensors to model device for EkfacInfluence implementation

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@mdbenito mdbenito added this to the v0.9.2 milestone May 3, 2024
@schroedk schroedk marked this pull request as ready for review May 3, 2024 09:47
@schroedk schroedk requested review from Xuzzo and mdbenito May 3, 2024 09:47
mdbenito
mdbenito previously approved these changes May 3, 2024
@schroedk schroedk removed their assignment May 3, 2024
@schroedk schroedk merged commit efa56e3 into develop May 3, 2024
35 checks passed
@schroedk schroedk deleted the fix/569-missing-device-move-ekfac branch May 8, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing move to device in influence_model.fit()
2 participants