Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve Control content #11

Merged
merged 11 commits into from
Nov 2, 2023
Merged

Conversation

AnesBenmerzoug
Copy link
Contributor

@AnesBenmerzoug AnesBenmerzoug commented Oct 24, 2023

This PR addresses some of the feedback we received and issues we encountered during the first iteration of the Control Training. This is related to issue #10

Changes

  • Add diagrams/concept maps to help participants navigate the field of Control Theory.
  • Remove slycot from the dependencies.
  • Add diagram explaining different approaches to solve the Optimal Control Problem.
  • Reorganize dependencies in pyproject.toml
  • Use multi-stage build in Dockerfile (This reduces the final image size to ~7GB and the largest layer being 5.47GB)
  • Add poetry.lock to dockerignore file.
  • Update readme instructions.
  • Skip rendering when running control notebooks inside a container.

@AnesBenmerzoug AnesBenmerzoug merged commit a37e49e into main Nov 2, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant