-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add git hooks #13
Conversation
- ignore merge commits - validate semmantic versioning - add Signed-off-by: - remove duplicate Signed-off-by Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
- SC2086: Double quote to prevent globbing and word splitting - SC3010 (warning): In POSIX sh, [[ ]] is undefined Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
@niteshkumar2000 @jeivardan Let me know if you'd like anything else done in terms of git hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aakashhemadri could we add linting to pre commit hook?
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
We absolutely could! To do what the github actions does we'd have to do a docker pull and run the docker image of the super linter github actions. quite easy actually and should be great! If y'all think that's a good idea we can do that |
- use ' instead of ` Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
Ah no no, that's too much.. I guess if dart analyse does it for dart code that should be enough right? |
Yeah otherwise also no problem we can slowly add! Just keep note of repetitive actions that you do before you commit! we can add that to pre-commit and commit-msg hooks. I have already added the Sign-off-by: as hooks |
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
- [warning] missing document start "---" (document-start) Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
- SC3040 (warning): In POSIX sh, set option pipefail is undefined. Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Good to go :)
Closes #12
Signed-off-by: Aakash Hemadri aakashhemadri123@gmail.com